Skip to content

Conversation

halvortf
Copy link
Member

Fixes issues regarding Released from and Released To

Summary:

  • Changed from Form.Control (input) to Form.Select
  • Made array of YEAR_OPTIONS in /frontend/src/constants/filterOptions.ts
  • Our imported games go from 1984-2020, so these years are included
  • yearTo options update accordingly to yearFrom option that is selected
  • If yearFrom is higher than yearTo (e.g. 2010-2005), yearTo = null

There should be no bugs regarding this merge (fingers crossed). Please check for yourselves. I couldn't find any.

Close #60 and #81 when merging

Halvor Thallaug Fagerli added 5 commits November 10, 2026 18:05
Min + max has been set for yearFrom and yearTo inputs, but only works for the arrows! Needs further work...
Added array with options for years for the "Year" Select objects in Toolbar.tsx
`yearFrom` and `yearTo` are now changeable via Select object rather than being input objects. `yearTo` only displays valid years (after `yearFrom`). Known bug: when changing `yearFrom` to a year ealier than `yearTo` and applying filter, `yearTo` changes to `Year`, but gives result "No games match these filters."
Fixes problems with #60 and #81 and eliminates problems when setting release year filters

#60 #81
@halvortf halvortf added the bug Something isn't working label Nov 15, 2026
@halvortf halvortf self-assigned this Nov 15, 2026
@halvortf halvortf requested a review from a team as a code owner November 15, 2026 13:18
Copy link
Member

@ayseza ayseza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing input to select ensures we get a valid year value. Tested and it does satisfy the issues mentioned in the feedback. Great work!

@ayseza ayseza merged commit bdf4c96 into dev Nov 15, 2026
@ayseza ayseza deleted the year_input_fix branch November 15, 2026 22:32
Sign in to join this conversation on GitHub.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants